Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simply the configuration for orchestration #1335

Merged
merged 23 commits into from
Oct 11, 2018
Merged

Simply the configuration for orchestration #1335

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6bb9297
modify dataSource()
tristaZero Oct 11, 2018
1ddbe5d
add Preconditions.checkState
tristaZero Oct 11, 2018
fc09c20
delete type
tristaZero Oct 11, 2018
a8951a8
delete type
tristaZero Oct 11, 2018
a879eb7
modify parser
tristaZero Oct 11, 2018
3cc9083
delete sharding.jdbc.config.orchestration.type for ms
tristaZero Oct 11, 2018
b1b7fc6
delete sharding.jdbc.config.orchestration.type for sharding
tristaZero Oct 11, 2018
2f9da60
add isValidRuleConfiguration()
tristaZero Oct 11, 2018
54f4962
delete check state
tristaZero Oct 11, 2018
6023285
add check state
tristaZero Oct 11, 2018
fc3c261
add check state
tristaZero Oct 11, 2018
030fbd2
delete ms check state
tristaZero Oct 11, 2018
0950664
add ms check state
tristaZero Oct 11, 2018
1268653
add ms check state
tristaZero Oct 11, 2018
8d2a943
add get orchestration type
tristaZero Oct 11, 2018
5742746
getOrchestrationTypeByRegistry()
tristaZero Oct 11, 2018
507ef5f
ConfigurationService configService = orchestrationFacade.getC…
tristaZero Oct 11, 2018
82e164c
adjust position
tristaZero Oct 11, 2018
a11f95e
use getOrchestrationType
tristaZero Oct 11, 2018
6e144fc
for checkstyle
tristaZero Oct 11, 2018
dbcfffc
return new ShardingRuleConfiguration();
tristaZero Oct 11, 2018
e013026
modify RELEASE-NOTES.md
tristaZero Oct 11, 2018
65be51d
modify RELEASE-NOTES-ZH.md
tristaZero Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modify parser
  • Loading branch information
@tristaZero
tristaZero committed Oct 11, 2018
commit a879eb71bad77269d7e3a832eb270364ad5d2dd5
1 change: 0 additions & 1 deletion ...re/shardingjdbc/orchestration/spring/namespace/parser/DataSourceBeanDefinitionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ private BeanDefinition getOrchestrationConfiguration(final Element element) {
factory.addConstructorArgValue(element.getAttribute(ID_ATTRIBUTE));
factory.addConstructorArgReference(element.getAttribute(ShardingDataSourceBeanDefinitionParserTag.REG_REF_TAG));
factory.addConstructorArgValue(element.getAttribute(ShardingDataSourceBeanDefinitionParserTag.OVERWRITE_TAG));
factory.addConstructorArgValue(orchestrationType);
return factory.getBeanDefinition();
}
}
Expand Down