Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modification for Hint. #1300

Merged
merged 26 commits into from
Sep 25, 2018
Merged

New modification for Hint. #1300

merged 26 commits into from
Sep 25, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #1289.

Changes proposed in this pull request:

  • Delete between Hint API.
  • Modify setDataBaseShardingValue API.
  • Modify some test cases.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5217

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 62.778%

Files with Coverage Reduction New Missed Lines %
sharding-core/src/main/java/io/shardingsphere/core/api/HintManager.java 1 94.12%
sharding-core/src/main/java/io/shardingsphere/core/executor/sql/prepare/SQLExecutePrepareTemplate.java 19 0.0%
Totals Coverage Status
Change from base Build 5211: -0.03%
Covered Lines: 8109
Relevant Lines: 12917

💛 - Coveralls

@terrymanu terrymanu merged commit a2d86d5 into apache:dev Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants