Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the sub classes of TextProtocolBackendHandler #8241

Closed
13 tasks done
kimmking opened this issue Nov 20, 2020 · 20 comments · Fixed by #8242, #8243 or guojia1698/shardingsphere#1
Closed
13 tasks done

Update the sub classes of TextProtocolBackendHandler #8241

kimmking opened this issue Nov 20, 2020 · 20 comments · Fixed by #8242, #8243 or guojia1698/shardingsphere#1
Labels
good first issue in: proxy type: refactor
Milestone
5.0.0-beta

Comments

@kimmking
Copy link
Member

kimmking commented Nov 20, 2020 •
edited
Loading

As method getRowData in TextProtocolBackendHandler has been modified, return type from list to collection.
Before:

public List<Object> getRowData();

After:

public Collection<Object> getRowData();

But all sub classes have not updated to Collection type as follow:

  • 1.BroadcastBackendHandler
  • 2.QueryBackendHandler
  • 3.RDLBackendHandler
  • 4.ShardingCTLExplainBackendHandler
  • 5.ShardingCTLHintBackendHandler
  • 6.ShardingCTLSetBackendHandler
  • 7.ShardingCTLShowBackendHandler
  • 8.ShowDatabasesBackendHandler
  • 9.ShowTablesBackendHandler
  • 10.SkipBackendHandler
  • 11.TransactionBackendHandler
  • 12.UnicastBackendHandler
  • 13.UseDatabaseBackendHandler

You should pick up one and

  1. modify getRowData return type to Collection
  2. remove useless imports
  3. mvn clean package to ensure all test work well
  4. submit a pr to this repo with a certain title: Update the sub class[your update class name here] of TextProtocolBackendHandler

    5. buddies, good luck and move on.

    It's the result:

    
1. @sydgeek           1
2. @Duelist-Fiora   2
3. @zenglinhui       3
4. @abysscat-yj     4
5. @guojia1698      5
6. @Jlif                     6
7. @sharpzhango   7
8. @plutokaito        8
9. @zhangwei1989 9
10. @lxl910128       10
11. @cutieagain       11
12. @sciatta              12
13. @Wincher           13
@kimmking kimmking added this to the 5.0.0-beta milestone Nov 20, 2020
@Wincher
Copy link
Contributor

Wincher commented Nov 20, 2020

get 13

@Jlif
Copy link
Contributor

Jlif commented Nov 20, 2020 •
edited
Loading

take 6.ShardingCTLSetBackendHandler

@plutokaito
Copy link
Contributor

plutokaito commented Nov 20, 2020 •
edited
Loading

get 8

@zhangwei1989
Copy link
Contributor

take mission 9

@whisper2u
Copy link
Contributor

get 7

@lxl910128
Copy link
Contributor

get 10.SkipBackendHandler

@Duelist-Fiora
Copy link
Contributor

get 2

@cutieagain
Copy link
Contributor

get 11

@onlyonezhongjinhui
Copy link

take 13.UseDatabaseBackendHandler

@zenglinhui
Copy link
Contributor

zenglinhui commented Nov 20, 2020 •
edited
Loading

get 3

@tangtian8
Copy link

get 8

@sydgeek
Copy link
Contributor

sydgeek commented Nov 20, 2020

take 1.BroadcastBackendHandler

@sciatta
Copy link
Contributor

sciatta commented Nov 20, 2020

get 12

@mcnultyboy
Copy link

get 6

@guojia1698
Copy link
Contributor

get 5

@branchen
Copy link

branchen commented Nov 20, 2020 •
edited
Loading

get 12

@abysscat-yj
Copy link
Contributor

get 4

@Lin1nGithub
Copy link

get6

@dongguabai
Copy link

get 1

@kimmking
Copy link
Member Author

Other buddies may be waiting next time.

Wincher added a commit to Wincher/shardingsphere that referenced this issue Nov 20, 2020
@Wincher
Update the sub classes of TextProtocolBackendHandler apache#8241
eed2857
@Wincher Wincher mentioned this issue Nov 20, 2020
Merged
@lxl910128 lxl910128 mentioned this issue Nov 20, 2020
Merged
terrymanu pushed a commit that referenced this issue Nov 20, 2020
@Wincher
Update the sub classes of TextProtocolBackendHandler #8241 (#8242)
aef4a68
@kimmking kimmking reopened this Nov 20, 2020
@kimmking kimmking reopened this Nov 20, 2020
Jlif pushed a commit to Jlif/shardingsphere that referenced this issue Nov 20, 2020
apache#8241 Update the sub class ShardingCTLSetBackendHandler of Text…
605ba11 
…ProtocolBackendHandler
@plutokaito plutokaito mentioned this issue Nov 20, 2020
Merged
@cutieagain cutieagain mentioned this issue Nov 20, 2020
Merged
Jlif pushed a commit to Jlif/shardingsphere that referenced this issue Nov 20, 2020
apache#8241 Update the sub class ShardingCTLSetBackendHandler of Text…
efb837f 
…ProtocolBackendHandler
@Jlif Jlif mentioned this issue Nov 20, 2020
Merged
@zhangwei1989 zhangwei1989 mentioned this issue Nov 21, 2020
Merged
@sciatta sciatta mentioned this issue Nov 21, 2020
Merged
terrymanu pushed a commit that referenced this issue Nov 21, 2020
@Jlif
#8241 Update the sub class ShardingCTLSetBackendHandler of TextProtoc…
0af539e 
…olBackendHandler (#8257)

Co-authored-by: jlif <jiangchen23@qq.com>
@terrymanu terrymanu mentioned this issue Nov 21, 2020
Merged
@Duelist-Fiora Duelist-Fiora mentioned this issue Nov 21, 2020
Merged
This was referenced Nov 21, 2020
Closed
Merged
@zenglinhui zenglinhui mentioned this issue Nov 22, 2020
Merged
@whisper2u whisper2u mentioned this issue Nov 22, 2020
Merged
@sydgeek sydgeek mentioned this issue Nov 22, 2020
Merged
@terrymanu terrymanu mentioned this issue Nov 22, 2020
Merged
@guojia1698 guojia1698 mentioned this issue Nov 22, 2020
Merged
Zhoutzzz pushed a commit to Zhoutzzz/shardingsphere that referenced this issue Dec 2, 2020
@Jlif @Zhoutzzz
apache#8241 Update the sub class ShardingCTLSetBackendHandler of Text…
066f649 
…ProtocolBackendHandler (apache#8257)

Co-authored-by: jlif <jiangchen23@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in: proxy type: refactor
Projects
None yet
Milestone
5.0.0-beta