Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider introduce the awaitility framework to replace Thread.sleep in E2E #24106

Open
5 tasks
zhaojinchao95 opened this issue Feb 10, 2023 · 9 comments
Open
5 tasks

Consider introduce the awaitility framework to replace Thread.sleep in E2E #24106

zhaojinchao95 opened this issue Feb 10, 2023 · 9 comments
Assignees
@liuxiaocs7
Labels
good pro issue in: test status: volunteer wanted type: refactor
Milestone
5.5.2

Comments

@zhaojinchao95
Copy link
Contributor

zhaojinchao95 commented Feb 10, 2023 •
edited
Loading

Hi community,

Now, many Thread.sleep code in E2E IT. It's aim to waiting meta data refresh. But sometimes, we needn't wait that long time, thus it increases IT run time. So we consider introduce awaitility to optimization it.

Task list :

  • shardingsphere-test-e2e-discovery @zhaojinchao95
  • shardingsphere-test-e2e-pipeline
  • shardingsphere-test-e2e-showprocesslist
  • shardingsphere-test-e2e-suite
  • shardingsphere-test-e2e-transaction
@zhaojinchao95 zhaojinchao95 added this to the 5.3.2 milestone Feb 10, 2023
This was referenced Feb 10, 2023
Merged
Closed
@TeslaCN TeslaCN modified the milestones: 5.3.2, 5.3.3 Mar 21, 2023
@liuxiaocs7
Copy link
Member

Hi, @zhaojinchao95, i want to have a try, please assign to me, thanks!

@zhaojinchao95
Copy link
Contributor Author

Hi, @zhaojinchao95, i want to have a try, please assign to me, thanks!

Welcome, which task do you do first?

@liuxiaocs7
Copy link
Member

liuxiaocs7 commented Mar 28, 2023 •
edited
Loading

Hi, @zhaojinchao95, I'll start from shardingsphere-test-e2e-showprocesslist, then shardingsphere-test-e2e-pipeline and shardingsphere-test-e2e-transaction, just to complete tasks from less to more, and submit PR separately, what do you think?

BTW, It seems that there is no such module shardingsphere-test-e2e-suite, do you means shardingsphere-test-e2e-env and shardingsphere-test-e2e-sql instead?

image

refer: https://github.com/awaitility/awaitility/wiki/Usage

@zhaojinchao95
Copy link
Contributor Author

I think your idea are very good, shardingsphere-test-e2e-suite already rename to shardingsphere-test-e2e-sql

@zhaojinchao95
Copy link
Contributor Author

@liuxiaocs7 Hi, any update?

@liuxiaocs7
Copy link
Member

liuxiaocs7 commented Apr 19, 2023 •
edited
Loading

Hi, @zhaojinchao95 , sorry for late and thanks for your reminder, I've been a little busy recently so I'm a little behind schedule. I'm free now and I'll keep updating this week!

@boyjoy1127
Copy link
Contributor

Will this issue be completed before June 15 which is the final date of version 5.4.0?

@wgy8283335 wgy8283335 modified the milestones: 5.4.0, 5.4.1 Jun 30, 2023
wangyuxiang123 pushed a commit to wangyuxiang123/shardingsphere that referenced this issue Jul 28, 2023
Refactor: test-e2e-sql use the awaitility framework replace sleep in …
9fdf1f0 
…RDLE2EIT class (apache#24106)
@wangyuxiang123 wangyuxiang123 mentioned this issue Jul 28, 2023
Merged
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Jul 30, 2023
@zhaojinchao95 zhaojinchao95 modified the milestones: 5.4.1, 5.4.2 Sep 27, 2023
@github-actions github-actions bot removed the stale label Sep 29, 2023
zhaojinchao95 pushed a commit that referenced this issue Oct 8, 2023
@wangyuxiang123
Refactor: test-e2e-sql use the awaitility framework replace sleep in …
db0098e 
…RDLE2EIT class (#27536)

* Refactor: test-e2e-sql use the awaitility framework replace sleep in RDLE2EIT class (#24106)

* Fix code style

* add SqlCommandType judgment in SingleE2EContainerComposer and  E2ETestParameterGenerator class

* Fix code style

* pollDelay() replace atMost() in the awaitility framework

* Fix code style

---------

Co-authored-by: wyx <=1105017602@qq.com>
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Mar 28, 2024
@zhaojinchao95 zhaojinchao95 removed this from the 5.5.0 milestone Apr 16, 2024
@zhaojinchao95 zhaojinchao95 added this to the 5.5.1 milestone Apr 16, 2024
@terrymanu terrymanu removed the stale label Jul 7, 2024
@taojintianxia taojintianxia modified the milestones: 5.5.1, 5.5.2 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuxiaocs7 liuxiaocs7

Labels
good pro issue in: test status: volunteer wanted type: refactor
Projects
None yet
Milestone
5.5.2
Development

No branches or pull requests
7 participants
@taojintianxia @terrymanu @TeslaCN @wgy8283335 @zhaojinchao95 @liuxiaocs7 @boyjoy1127