Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the agent shade plugin usage #23178

Closed
4 tasks done
taojintianxia opened this issue Dec 30, 2022 · 0 comments · Fixed by #23203
Closed
4 tasks done

refactor the agent shade plugin usage #23178

taojintianxia opened this issue Dec 30, 2022 · 0 comments · Fixed by #23203
Assignees
@taojintianxia
Labels
feature: agent shardingsphere agent type: build type: refactor
Milestone
5.3.1

Comments

@taojintianxia
Copy link
Contributor

taojintianxia commented Dec 30, 2022 •
edited
Loading

There is some confusion about the usage of the shade plugin in the agent, that will make the artifact chaos, some of these should not be packaged.

refacor the shade plugin in agent to make it more clear by following missions :

  • relocation should be config in submodule, not on the top parent pom.i.e. zipkin packing config should in pom under zipkin, not in pom under plugins
  • every single thrid party dependency should be relocated, except three common dependencies : guava、bytebuddy、snakeyaml, these three dependencies will be packaged in bootsrap
  • every submodule shade plugin must use the shade config minimizeJar
  • refactor the assembly file for upon changes
@taojintianxia taojintianxia self-assigned this Dec 30, 2022
@taojintianxia taojintianxia mentioned this issue Dec 30, 2022
Merged
6 tasks
terrymanu pushed a commit that referenced this issue Dec 31, 2022
@taojintianxia
Refactor agent shade plugin usage (#23203)
fd87956 
* Refactor : change the zipkin packging usage (#23178)

* Refactor : refactor the maven shade plugin structure in agent module (#23178)

* Fix : fix an incorrect path of target (#23178)
@taojintianxia taojintianxia added this to the 5.3.1 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taojintianxia taojintianxia

Labels
feature: agent shardingsphere agent type: build type: refactor
Projects
None yet
Milestone
5.3.1
Development

Successfully merging a pull request may close this issue.

Refactor agent shade plugin usage
1 participant
@taojintianxia