[GH-2525] bug: Make ST_Force3D return multipolygons even if it's a single polygon inside #2526
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petern48
commented
Nov 25, 2025
| return transformer.transform(geometry); | ||
| } | ||
|
|
||
| protected Geometry transformMultiPolygon(MultiPolygon geom, Geometry parent) { |
Collaborator
Author
There was a problem hiding this comment.
This is simply an override of this method in JTS's GeometryTransformer class to handle MultiPolygons separately.
Collaborator
Author
|
R Build failure is unrelated. Looks like it's already in the process of being fixed: #2524 |
jiayuasu
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes bug: ST_Force3d() returns polygon when input is multipolygon with a single nested polygon #2525What changes were proposed in this PR?
When ST_Force3D received a MultiPolygon as input, it would previously downgrade it into a Polygon if possible. This PR makes it return a multipolygon even if it's a single polygon inside, which is the same behavior as Postgis.
How was this patch tested?
Added tests
Did this PR include necessary documentation updates?