[GH-2513] chore(python): Make 'assert_geometry_almost_equal' check for Z and M dimensions too #2517
+85
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for shapely>=2.1.0
petern48
commented
Nov 23, 2025
Comment on lines
+131
to
+133
| Note: this function will only check Z and M dimensions for shapely >= 2.1.0 (python >= 3.10) | ||
| When comparing geometries with Z or M dimensions, this function will ignore `tolerance` and check for exact equality. |
Collaborator
Author
There was a problem hiding this comment.
Reasons for this:
-
Z and M support isn't introduced until Shapely 2.1.0
equals_exactonly compares X and Y dimensions and not Z/M (as mentioned here in the equals_identical docs, but not the equals_exact docs...)
-
We now use
equals_identicalto check Z/M, but it doesn't support atoleranceparameter. I think this is fine, given the rare need for tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes chore(geopandas): Makecheck_sgpd_equals_gpd()test for Z and M dimensions too #2513What changes were proposed in this PR?
Make 'assert_geometry_almost_equal' check for Z and M dimensions too for shapely >= 2.1.0
How was this patch tested?
Added test
Did this PR include necessary documentation updates?