[Fix][Core] Add shade module for apache commons lang3 #9895
+661
−566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Sep 26, 2025
| */ | ||
| package org.apache.seatunnel.core.starter.enums; | ||
|
|
||
| import org.apache.commons.lang3.math.NumberUtils; |
There was a problem hiding this comment.
Let's add a shade module for apache commons lang3? So that it can never conflict. And we can upgrade it easier.
There was a problem hiding this comment.
Extract shade? Shade generally doesn't change much, so there's no need to upgrade along with the seatunnel version. This can effectively reduce the build time.
There was a problem hiding this comment.
Yep. We can do it in another patch after seatunnel-shade repository ready.
…x/no_field_is_java1.8 # Conflicts: # seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ServerExecuteCommand.java
github-actions
bot
added
Spark
Zeta
connectors-v2
Transform-v2
Zeta Rest API
e2e
format
api
labels
xiaochen-zhou
changed the title
use PeekBlockingQueue jobId map
xiaochen-zhou
force-pushed
the
fix/no_field_is_java1.8
branch
from
bc8a528 to
483b679
Compare
github-actions
bot
added
the
dependencies
Hisoka-X
approved these changes
Sep 30, 2025
corgy-w
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
During SeaTunnel startup, the common.lang3 package introduced by connectors may be loaded randomly,
Potentially causing a NoSuchFieldError: IS_JAVA_1_8:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Exist Test: ServerExecuteCommandTest#testJavaVersionCheck()
Check list
New License Guide