Skip to content

Conversation

liuwei178
Copy link
Contributor

@liuwei178 liuwei178 commented Aug 25, 2025

Purpose of this pull request

1、Support vector series sql function
2、close #9663

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwei178 ! Please update the docs.

@liuwei178 liuwei178 closed this Aug 26, 2025
@liuwei178 liuwei178 reopened this Aug 26, 2025
@liuwei178
Copy link
Contributor Author

Thanks @liuwei178 ! Please update the docs.

@Hisoka-X The documents have been added, please review the code when you have time.

Comment on lines 46 to 47
new float[] {1.0f, 2.0f, 3.0f},
new float[] {1.0f, 2.0f, 3.0f}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In seatunnel, we use ByteBuffer to store VECTOR_FLOAT_TYPE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve the test cases and test ok

}
}

private static Float[] convertSparseVectorToFloatArray(Map<?, ?> sparseVector) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this method into BufferUtils. And rename BufferUtils to VectorUtils.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been adjusted. The CI process is running ,but a bit slow.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @liuwei178

@corgy-w corgy-w merged commit a40114c into apache:dev Aug 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Transform-V2] Support vector series sql function

3 participants