-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Feature][Transform-V2] Support vector series sql function #9765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Transform-V2] Support vector series sql function #9765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liuwei178 ! Please update the docs.
@Hisoka-X The documents have been added, please review the code when you have time. |
new float[] {1.0f, 2.0f, 3.0f}, | ||
new float[] {1.0f, 2.0f, 3.0f} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In seatunnel, we use ByteBuffer to store VECTOR_FLOAT_TYPE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve the test cases and test ok
} | ||
} | ||
|
||
private static Float[] convertSparseVectorToFloatArray(Map<?, ?> sparseVector) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this method into BufferUtils
. And rename BufferUtils
to VectorUtils
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been adjusted. The CI process is running ,but a bit slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes. Thanks @liuwei178
Purpose of this pull request
1、Support vector series sql function
2、close #9663
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide