-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Zeta] when job finished, the checkpoint won't write to file #6674
Conversation
Please add test case to verify no file in checkpoint directory when job finished, also need add test case to make sure file would generate when job done with savepoint. |
Yes, will do it |
9008182
to
9218198
Compare
@Hisoka-X PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @liunaijie !
.pipelineId(pipelineId) | ||
.states(states) | ||
.build()); | ||
if (completedCheckpoint.getCheckpointType().notCompletedCheckpoint()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an annotation to this method indicating that it represents a batch type
Line 94 in 058f559
public boolean notCompletedCheckpoint() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the judgment here is for batch processing, but currently the checkpoint type cannot be associated with batch processing
Purpose of this pull request
close #6670
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.