Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]Change System.out.println to log output. #5912

Merged
merged 4 commits into from
Nov 25, 2023
Merged

[Improve]Change System.out.println to log output. #5912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8629fc
Change System.out.println to log output.
Nov 24, 2023
e22a4f5
remove starter module change.
Nov 24, 2023
2d80e9b
remove starter module change.
Nov 24, 2023
65449cd
update test.
Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove starter module change.
  • Loading branch information
lightzhao committed Nov 24, 2023
commit 2d80e9b818322d4b5f8276aed6dba008e51d7eef
5 changes: 1 addition & 4 deletions ...-flink-13-starter/src/main/java/org/apache/seatunnel/core/starter/flink/FlinkStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,11 @@
import org.apache.seatunnel.core.starter.flink.args.FlinkCommandArgs;
import org.apache.seatunnel.core.starter.utils.CommandLineUtils;

import lombok.extern.slf4j.Slf4j;

import java.util.ArrayList;
import java.util.List;
import java.util.Objects;

/** The SeaTunnel flink starter, used to generate the final flink job execute command. */
@Slf4j
public class FlinkStarter implements Starter {
private static final String APP_NAME = SeaTunnelFlink.class.getName();
public static final String APP_JAR_NAME = EngineType.FLINK13.getStarterJarName();
Expand All @@ -49,7 +46,7 @@ public class FlinkStarter implements Starter {

public static void main(String[] args) {
FlinkStarter flinkStarter = new FlinkStarter(args);
log.info(String.join(" ", flinkStarter.buildCommands()));
System.out.println(String.join(" ", flinkStarter.buildCommands()));
}

@Override
Expand Down
5 changes: 1 addition & 4 deletions ...nk-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/FlinkStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,11 @@
import org.apache.seatunnel.core.starter.flink.args.FlinkCommandArgs;
import org.apache.seatunnel.core.starter.utils.CommandLineUtils;

import lombok.extern.slf4j.Slf4j;

import java.util.ArrayList;
import java.util.List;
import java.util.Objects;

/** The SeaTunnel flink starter, used to generate the final flink job execute command. */
@Slf4j
public class FlinkStarter implements Starter {
private static final String APP_NAME = SeaTunnelFlink.class.getName();
public static final String APP_JAR_NAME = EngineType.FLINK15.getStarterJarName();
Expand All @@ -49,7 +46,7 @@ public class FlinkStarter implements Starter {

public static void main(String[] args) {
FlinkStarter flinkStarter = new FlinkStarter(args);
log.info(String.join(" ", flinkStarter.buildCommands()));
System.out.println(String.join(" ", flinkStarter.buildCommands()));
}

@Override
Expand Down
5 changes: 1 addition & 4 deletions ...l-spark-2-starter/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

import org.apache.commons.lang3.StringUtils;

import lombok.extern.slf4j.Slf4j;

import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
Expand All @@ -60,7 +58,6 @@
import java.util.stream.Stream;

/** A Starter to generate spark-submit command for SeaTunnel job on spark. */
@Slf4j
public class SparkStarter implements Starter {

/** original commandline args */
Expand All @@ -86,7 +83,7 @@ private SparkStarter(String[] args, SparkCommandArgs commandArgs) {
public static void main(String[] args) throws IOException {
SparkStarter starter = getInstance(args);
List<String> command = starter.buildCommands();
log.info(String.join(" ", command));
System.out.println(String.join(" ", command));
}

/**
Expand Down
5 changes: 1 addition & 4 deletions ...rk-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

import org.apache.commons.lang3.StringUtils;

import lombok.extern.slf4j.Slf4j;

import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
Expand All @@ -60,7 +58,6 @@
import java.util.stream.Stream;

/** A Starter to generate spark-submit command for SeaTunnel job on spark. */
@Slf4j
public class SparkStarter implements Starter {

/** original commandline args */
Expand All @@ -86,7 +83,7 @@ private SparkStarter(String[] args, SparkCommandArgs commandArgs) {
public static void main(String[] args) throws IOException {
SparkStarter starter = getInstance(args);
List<String> command = starter.buildCommands();
log.info(String.join(" ", command));
System.out.println(String.join(" ", command));
}

/**
Expand Down