Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on kudu #5789

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

Carl-Zhou-CN
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN commented Nov 6, 2023

close #5720

Purpose of this pull request

TableSourceFactory/TableSinkFactory on kudu

Does this PR introduce any user-facing change?

How was this patch tested?

Current e2e test

Check list

@Carl-Zhou-CN
Copy link
Member Author

@hailin0 @Hisoka-X Please help review, thank you

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carl-Zhou-CN . Please remove setTypeInfo and prepare method in KuduSink, remove prepare method in KuduSource. After we implement TableSourceFactory/TableSinkFactory it will never be used.

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 6, 2023

Please answer this question in PR template:
How was this patch tested?

Hisoka-X
Hisoka-X previously approved these changes Nov 7, 2023
EricJoy2048
EricJoy2048 previously approved these changes Nov 7, 2023
TableSourceFactory/TableSinkFactory on kudu
TableSourceFactory/TableSinkFactory on kudu
@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 7, 2023

@hailin0
Copy link
Member

hailin0 commented Nov 7, 2023

waiting for this pr merge
#5798

image

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 7, 2023

Please merge from dev to retrigger CI.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carl-Zhou-CN !

@Hisoka-X Hisoka-X merged commit 10e791d into apache:dev Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on kudu
5 participants