Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Shade][typesafe-config] Make Config can be serialized #4586

Merged
merged 5 commits into from
May 12, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Check list

@hailin0
Copy link
Member

hailin0 commented Apr 16, 2023

for reference only
lightbend/config#49 (comment)

@TyrantLucifer TyrantLucifer force-pushed the make-config-serialized branch 2 times, most recently from 6d1064e to 485d520 Compare April 23, 2023 10:40
Hisoka-X
Hisoka-X previously approved these changes Apr 24, 2023
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0
Copy link
Member

hailin0 commented Apr 25, 2023

check ci error

@TyrantLucifer TyrantLucifer force-pushed the make-config-serialized branch from d8d5008 to 90c3e88 Compare April 28, 2023 07:09
@EricJoy2048 EricJoy2048 force-pushed the make-config-serialized branch 2 times, most recently from a11ad19 to f977033 Compare May 5, 2023 09:32
@EricJoy2048 EricJoy2048 force-pushed the make-config-serialized branch from f977033 to bfe77f9 Compare May 5, 2023 09:34
@TyrantLucifer TyrantLucifer reopened this May 5, 2023
@EricJoy2048 EricJoy2048 closed this May 6, 2023
@EricJoy2048 EricJoy2048 reopened this May 6, 2023
@EricJoy2048 EricJoy2048 closed this May 6, 2023
@EricJoy2048 EricJoy2048 reopened this May 6, 2023
@TyrantLucifer TyrantLucifer reopened this May 9, 2023
@EricJoy2048 EricJoy2048 reopened this May 10, 2023
@Hisoka-X Hisoka-X merged commit 9725a42 into apache:dev May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants