Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Zeta][Config] change Zeta config #4043

Merged
merged 5 commits into from
Feb 14, 2023
Merged

[Improve][Zeta][Config] change Zeta config #4043

merged 5 commits into from
Feb 14, 2023

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Feb 3, 2023

Purpose of this pull request

Check list

@liugddx
Copy link
Member Author

liugddx commented Feb 3, 2023

#4044

@liugddx
Copy link
Member Author

liugddx commented Feb 3, 2023

This configuration can isolate the rest api.

EricJoy2048
EricJoy2048 reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest enable the zeta e2e test to test this pr.

config/hazelcast-client.yaml Outdated Show resolved Hide resolved
Hisoka-X
Hisoka-X reviewed Feb 13, 2023
View reviewed changes
config/hazelcast-client.yaml
@@ -21,4 +21,4 @@ hazelcast-client:
hazelcast.logging.type: log4j2
network:
cluster-members:
- localhost:5801
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Why change port to 9000?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Why change port to 9000?

Can we keep using port 5801? Some of our users are already using seatunnel cluster, and modifying the port will have some impact.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@liugddx liugddx merged commit 7ef2ef8 into apache:dev Feb 14, 2023
@liugddx liugddx deleted the improve-2 branch February 14, 2023 13:12
TyrantLucifer added a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Feb 16, 2023
@TyrantLucifer
Revert "[Improve][Zeta][Config] change Zeta config (apache#4043)"
f8a21df 
This reverts commit 7ef2ef8.
@TyrantLucifer TyrantLucifer mentioned this pull request Feb 16, 2023
Merged
5 tasks
liugddx pushed a commit that referenced this pull request Feb 17, 2023
@TyrantLucifer
Revert "[Improve][Zeta][Config] change Zeta config (#4043)" (#4152)
9433fa2 
This reverts commit 7ef2ef8.
liugddx added a commit that referenced this pull request Feb 18, 2023
@liugddx
Revert "Revert "[Improve][Zeta][Config] change Zeta config (#4043)" (#…
9954a1e 
…4152)"

This reverts commit 9433fa2.
liugddx added a commit to liugddx/seatunnel that referenced this pull request Mar 19, 2023
@liugddx
Revert "Revert "[Improve][Zeta][Config] change Zeta config (apache#4043…
da36ac7 
…)" (apache#4152)"

This reverts commit 9433fa2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
approved improve reviewed Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liugddx @EricJoy2048 @Hisoka-X