-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][KafkaSource]Fix commit kafka offset bug. #3933
[Bug][KafkaSource]Fix commit kafka offset bug. #3933
Conversation
@Hisoka-X @TyrantLucifer PTAL. |
I will close this PR, if you have any other suggestion or problem, please reopen it. Thanks! |
@Hisoka-X Offset starts from 0. When submitting, it should be +1. Otherwise, the lag is always missing 1. I have verified it in the test environment. You can also try it. |
@Hisoka-X hello, I don't seem to have permission to reopen this PR. Can you reopen it? My test is really a bug. You can test it here。 |
I got your point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed a bug, thank you for your unremitting efforts
Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
After the checkpoint is completed, the offset will be submitted to kafka. The offset of the submitted partition should be KafkaSourceSplit:: getStartOffset. Otherwise, some offsets are not submitted successfully, resulting in repeated data consumption.
Purpose of this pull request
Check list
New License Guide
release-note
.