-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][KafkaSource]Failed to parse offset format #3810
Conversation
…as a "-", the exception will be resolved, causing the assignment to fail
PTAL @Carl-Zhou-CN |
@TaoZex @Carl-Zhou-CN please review, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hi, Please update doc to add this change to change-log |
cf36a81
done, thanks. please merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
* When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail * fix code style. * update change-log Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
* When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail * fix code style. * update change-log Co-authored-by: zhaoliang01 <zhaoliang01@58.com>
When the kafka source is started in offset mode, when the topicName has a "-", the exception will be resolved, causing the assignment to fail.
example:
start_mode = "specific_offsets"
start_mode.offsets = {
my-topic-test-0 = 1
}
topicName is my, partition is topic-test-0.
Purpose of this pull request
Check list
New License Guide