Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Engine][Checkpoint]Unified naming style #3714

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[Engine][Checkpoint]Unified naming style #3714

merged 2 commits into from
Dec 13, 2022

Conversation

CalvinKirs
Copy link
Member

update storageNameSpace to namespace

@CalvinKirs
[Engine][Checkpoint]Unified naming style
18517db 
update storageNameSpace to namespace
@CalvinKirs CalvinKirs added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Dec 13, 2022
liugddx
liugddx previously approved these changes Dec 13, 2022
View reviewed changes
dijiekstra
dijiekstra approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@dijiekstra dijiekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dijiekstra dijiekstra merged commit bc0bd3b into apache:dev Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@dijiekstra dijiekstra dijiekstra approved these changes

@liugddx liugddx liugddx left review comments

Assignees
No one assigned
Labels
approved chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CalvinKirs @zhongjiajie @dijiekstra @liugddx