Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CheckStyle]Remove scala-checkstyle that is no longer in use #3261

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[CheckStyle]Remove scala-checkstyle that is no longer in use #3261

merged 1 commit into from
Nov 2, 2022

Conversation

CalvinKirs
Copy link
Member

scala-check-style is mainly used for V1connector checks, we haven't had new V1 contributed code for a long time and V1 will be removed from the dev branch later,
also, for special reasons scala check needs to install the whole project in advance,
so I recommend removing it.

scala-check-style is mainly used for V1connector checks, we haven't had new V1 contributed code for a long time and V1 will be removed from the dev branch later, also, for special reasons scala check needs to install the whole project in advance, so I recommend removing it.
@CalvinKirs CalvinKirs changed the title [CheckStyle]Remove scal-checkstyle that is no longer in use [CheckStyle]Remove scala-checkstyle that is no longer in use Nov 2, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 087f3ae into apache:dev Nov 2, 2022
@CalvinKirs CalvinKirs deleted the rm-scala-check branch November 2, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants