Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [flink-connector-jdbc]change jdbc Source connector to get fields from jdbc meta data and support oracle database #1781

Merged
merged 8 commits into from
May 6, 2022

Conversation

gleiyu
Copy link
Contributor

@gleiyu gleiyu commented Apr 30, 2022

Purpose of this pull request

  1. support to get fields from jdbc database metadata
  2. support oracle database
  3. remove functions with regex
  4. change extend partition function to support complex sql

related issue: #1779 #1709

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented May 5, 2022

Nice done. Please make build pass.

@gleiyu
Copy link
Contributor Author

gleiyu commented May 5, 2022

please check again

Hisoka-X
Hisoka-X previously approved these changes May 5, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ruanwenjun PTAL

@gleiyu
Copy link
Contributor Author

gleiyu commented May 5, 2022

fixed getRowInfo function to get the missing field

@gleiyu
Copy link
Contributor Author

gleiyu commented May 6, 2022

@ruanwenjun please check again

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use StringUtils

@gleiyu gleiyu requested a review from ruanwenjun May 6, 2022 08:55
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 1a368dc into apache:dev May 6, 2022
@ruanwenjun ruanwenjun added flink connectors-v1 SeaTunnel connectors, include sink, source labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connectors-v1 SeaTunnel connectors, include sink, source flink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants