Skip to content

Conversation

tmljob
Copy link
Contributor

@tmljob tmljob commented Apr 27, 2022

Purpose of this pull request

1、Rename Webhook to WebhookStream to ensure it is recognized as a stream processing plugin.
2、Use java.sql.Timestamp instead of java.util.Date to avoid the following runtime errors.
No Encoder found for java.util.Date
3、Add the dependency of the webhook plugin to the seatunnel-core-spark project.

4、Fix META-INF/services wrong path named META-INF.services

5、Synchronously modify the documentation of the webhook plugin

Check list

@tmljob tmljob changed the title Improve webhook connector [Bug][Connector]fix runtime errors of webhook connector Apr 27, 2022
@tmljob tmljob requested a review from ruanwenjun April 28, 2022 01:59
@tmljob tmljob requested a review from ruanwenjun April 28, 2022 02:31
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will merge after CI pass if no other concern.

@ruanwenjun ruanwenjun added the connectors-v1 SeaTunnel connectors, include sink, source label Apr 28, 2022
@ruanwenjun ruanwenjun merged commit be92f6f into apache:dev Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connectors-v1 SeaTunnel connectors, include sink, source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants