[Build][Deps] Support JDK23 lombok annotation processing#10887
Draft
DanielLeens wants to merge 1 commit into
Draft
[Build][Deps] Support JDK23 lombok annotation processing#10887DanielLeens wants to merge 1 commit into
DanielLeens wants to merge 1 commit into
Conversation
DanielLeens
force-pushed
the
daniel-st-jdk23-lombok-fix
branch
from
2c1a4d9 to
dfb7185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix JDK23 build compatibility for modules that rely on lombok-generated constructors, getters, and loggers.
This change:
lombok.versionfrom1.18.24to1.18.36maven-compiler-pluginannotationProcessorPathsWhy is this needed?
On JDK23, the
connector-cdc-basemodule fails duringcompile/testCompilebecause lombok annotation processing is not applied.Typical failures include missing generated getters, constructors, and
logfields.How was this verified?
Ran in a JDK23 environment:
./mvnw spotless:apply ./mvnw -pl seatunnel-connectors-v2/connector-cdc/connector-cdc-base \ -Dgit.skip=true -Dmaven.gitcommitid.skip=true \ -Dtest=HybridSplitAssignerTest testThe targeted CDC module build and test now pass successfully under JDK23.