Skip to content

[Improve][Connecotr-v2][Databend] Optimize CI judgment logic #10130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+20 −20
Open

[Improve][Connecotr-v2][Databend] Optimize CI judgment logic #10130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e77a14
[Improve][Databend] Replace Thread.sleep with Awaitility for efficien…
zhangshenghang Nov 29, 2025
e5a46d5
[Improve][Databend] Replace Thread.sleep with Awaitility for efficien…
zhangshenghang Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions ...bend-e2e/src/test/java/org/apache/seatunnel/e2e/connector/databend/DatabendCDCSinkIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,26 @@ public void testDatabendSinkCDC(TestContainer container) throws Exception {
container.executeJob("/databend/fake_to_databend_cdc.conf");
Assertions.assertEquals(0, execResult.getExitCode(), execResult.getStderr());

// Wait for the merge operation to complete
// Increased wait time to ensure merge operations finish
Thread.sleep(10000);
Awaitility.await()
.atMost(120, TimeUnit.SECONDS)
.pollInterval(1, TimeUnit.SECONDS)
.ignoreExceptions()
.untilAsserted(
() -> {
try (Statement stmt = connection.createStatement();
ResultSet rs =
stmt.executeQuery(
"SELECT COUNT(*) as count FROM sink_table")) {
if (rs.next()) {
int count = rs.getInt("count");
LOG.info(
"Current record count in sink_table: {}, expecting 3",
count);
Assertions.assertEquals(
3, count, "Expected 3 records in sink_table");
}
}
});

// Verify the sink results
try (Statement statement = connection.createStatement()) {
Expand Down Expand Up @@ -270,23 +287,6 @@ private boolean createMinIOBucketWithAWSSDK(String bucketName) {
}
}

// private synchronized Connection getConnection() throws SQLException {
// if (this.connection == null || this.connection.isClosed()) {
// LOG.info("Creating new database connection");
// final Properties info = new Properties();
// info.put("user", "root");
// info.put("password", "");
//
// String jdbcUrl =
// String.format(
// "jdbc:databend://%s:%d/%s?ssl=false",
// container.getHost(), container.getMappedPort(8000), DATABASE);
//
// this.connection = DriverManager.getConnection(jdbcUrl, info);
// }
// return this.connection;
// }

private void initConnection()
throws SQLException, ClassNotFoundException, InstantiationException,
IllegalAccessException {
Expand Down