SAMZA-1926: Fix standalone configurations in configuration table. #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xinyuiscool @prateekm Please take a look when you get a chance. |
prateekm
requested changes
Oct 1, 2018
samza-core/src/main/java/org/apache/samza/config/JobCoordinatorConfig.java
Outdated
Show resolved
Hide resolved
|
|
||
| public String getJobCoordinationUtilsFactoryClassName() { | ||
| String className = get(JOB_COORDINATION_UTILS_FACTORY, DEFAULT_COORDINATION_UTILS_FACTORY); | ||
| String coordinatorFactory = get(JOB_COORDINATOR_FACTORY, DEFAULT_COORDINATOR_UTILS_FACTORY); |
Contributor
There was a problem hiding this comment.
Why default coordinator utils factory? Did you mean default coordinator factory?
Contributor
Author
There was a problem hiding this comment.
Yes, typo. Fixed.
samza-core/src/main/java/org/apache/samza/config/JobCoordinatorConfig.java
Show resolved
Hide resolved
shanthoosh
commented
Oct 1, 2018
Contributor
Author
shanthoosh
left a comment
shanthoosh
left a comment
There was a problem hiding this comment.
Thanks for the review.
samza-core/src/main/java/org/apache/samza/config/JobCoordinatorConfig.java
Show resolved
Hide resolved
|
|
||
| public String getJobCoordinationUtilsFactoryClassName() { | ||
| String className = get(JOB_COORDINATION_UTILS_FACTORY, DEFAULT_COORDINATION_UTILS_FACTORY); | ||
| String coordinatorFactory = get(JOB_COORDINATOR_FACTORY, DEFAULT_COORDINATOR_UTILS_FACTORY); |
Contributor
Author
There was a problem hiding this comment.
Yes, typo. Fixed.
samza-core/src/main/java/org/apache/samza/config/JobCoordinatorConfig.java
Outdated
Show resolved
Hide resolved
* Fix the default value of debounce time configuration. * Remove the coordination utils configuration from the table(Infer that based upon job.coordinator.factory configuration). Remove the defintion of coordination utils factory in configuration from unit-tests. * Default job.coordinator.factory to ZkJobCoordinatorFactory if it is not defined by the user.
prateekm
reviewed
Oct 2, 2018
samza-core/src/main/java/org/apache/samza/config/JobCoordinatorConfig.java
Outdated
Show resolved
Hide resolved
Contributor
|
@vjagadish1989 Do these changes look reasonable? |
vjagadish1989
approved these changes
Oct 5, 2018
vjagadish1989
approved these changes
Oct 5, 2018
Contributor
vjagadish1989
left a comment
vjagadish1989
left a comment
There was a problem hiding this comment.
one comment, otherwise good to merge
| <td class="description"> | ||
| Class to use for job coordination. Currently available values are: | ||
| The fully-qualified name of the Java class which determines the factory class which will build the JobCoordinator. | ||
| The default configuration value if the property is not present is <code>job.coordinator.factory=org.apache.samza.zk.ZkJobCoordinatorFactory</code>.<br> |
Contributor
There was a problem hiding this comment.
"The default configuration value if the property is not present is job.coordinator.factory=org.apache.samza.zk.ZkJobCoordinatorFactory" -> recommend deleting this line.
Contributor
|
merged and submitted. @prateekm and @shanthoosh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
coordination.utils.factoryconfiguration from the table(Infer that based upon job.coordinator.factory configuration). Remove the definition ofcoordination.utils.factoryfrom the configuration in unit tests.job.coordinator.factorytoZkJobCoordinatorFactoryif it is not defined by the user.