Skip to content

Conversation

@majialoong
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9784

Brief Description

Use correct policy judgment logic to give DENY a higher priority than ALLOW.

How Did You Test This Change?

Verification using unit tests.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.31%. Comparing base (bea086f) to head (c1de64f).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9785      +/-   ##
=============================================
- Coverage      48.37%   48.31%   -0.07%     
+ Complexity     12248    12233      -15     
=============================================
  Files           1314     1314              
  Lines          93668    93670       +2     
  Branches       12011    12012       +1     
=============================================
- Hits           45316    45252      -64     
- Misses         42757    42813      +56     
- Partials        5595     5605      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majialoong
Copy link
Contributor Author

Hi, @dingshuangxi888 @lizhimins. PTAL. Thanks !

Copy link
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit d7c8bb7 into apache:develop Nov 3, 2025
15 of 18 checks passed
@majialoong majialoong deleted the ISSUE-9784 branch November 3, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix the policy comparator to prioritize DENY over ALLOW

4 participants