Skip to content

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9737

Brief Description

How Did You Test This Change?

fuyou001
fuyou001 previously approved these changes Sep 26, 2025
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caigy
caigy previously approved these changes Sep 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.13%. Comparing base (64999c1) to head (0c64224).

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 30.76% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9740      +/-   ##
=============================================
- Coverage      48.23%   48.13%   -0.11%     
+ Complexity     12171    12144      -27     
=============================================
  Files           1313     1313              
  Lines          93340    93340              
  Branches       11962    11963       +1     
=============================================
- Hits           45025    44928      -97     
- Misses         42746    42829      +83     
- Partials        5569     5583      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qianye1001 qianye1001 marked this pull request as draft September 26, 2025 03:38
@qianye1001 qianye1001 dismissed stale reviews from caigy and fuyou001 via ab90545 September 28, 2025 07:35
@qianye1001 qianye1001 marked this pull request as ready for review September 28, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Client memory leak on connection failure

5 participants