[ISSUE #9738] Remove macOS platform skip logic from test cases to improve cross-platform compatibility #9739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Assume.assumeFalse(MixAll.isMac()) calls from test methods - Remove macOS platform detection conditions in setUp/tearDown methods - Update RocksdbTransferOffsetAndCqTest.notToBeExecuted() to return false - Remove unused imports: org.junit.Assume and org.apache.rocketmq.common.MixAll - Enable full test coverage on macOS platform Affected modules: - Broker config management tests (ConsumerOffsetManagerV2, SubscriptionGroupManagerV2, TopicConfigManagerV2) - RocksDB related tests (LmqConsumerOffsetManager, OffsetSerializeWrapper, TransferOffsetAndCq) - POP consumer tests (PopConsumerCache, PopConsumerRocksdbStore) - Store layer tests (HAServer, CombineConsumeQueueStore, RocksDBConsumeQueueOffsetTable) - Other component tests (CQType, ExportRocksDBConfigToJsonRequestHeader) This change improves platform compatibility by ensuring all tests run on macOS instead of being skipped due to platform detection. Change-Id: I59af05d0b1159107b6f1fbd10290d283f87e0e41 Co-developed-by: Cursor <noreply@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9739 +/- ##
=============================================
- Coverage 48.19% 48.16% -0.03%
+ Complexity 12168 12151 -17
=============================================
Files 1313 1313
Lines 93340 93340
Branches 11962 11962
=============================================
- Hits 44988 44961 -27
- Misses 42777 42804 +27
Partials 5575 5575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 2 commits
September 26, 2025 15:10
Change-Id: Ia9da2718c0ce8e09a656cdd312215c472be29390
Change-Id: Ib0769407fd88c055127afeca306f94f857785769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected modules:
This change improves platform compatibility by ensuring all tests run on macOS instead of being skipped due to platform detection.
Change-Id: I59af05d0b1159107b6f1fbd10290d283f87e0e41
Co-developed-by: Cursor noreply@cursor.com
Which Issue(s) This PR Fixes
Fixes #9738
Brief Description
How Did You Test This Change?