Skip to content

Conversation

ymwneu
Copy link
Contributor

@ymwneu ymwneu commented Sep 2, 2025

Which Issue(s) This PR Fixes

Fixes #9654

Brief Description

There is a variable called bufferLocal in TimerMessageStore, which is used to store a single message from the commitlog. The initial size of bufferLocal is currently set to maxMessageSize plus 100 bytes. Since some properties may be added during the intermediate stages of scheduled messages, the maximum message size can exceed maxMessageSize. Although an extra 100 bytes is reserved during initialization, in some scenarios this is not sufficient, resulting in message read failures and subsequently blocking the entire scheduled message process.

How Did You Test This Change?

@lizhimins lizhimins changed the title Optimize the bufferLocal size of the TimerMessageStore [ISSUE #9654] Optimize the bufferLocal size of the TimerMessageStore Sep 2, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.01%. Comparing base (2954655) to head (a3bc52f).

Files with missing lines Patch % Lines
...ache/rocketmq/store/config/MessageStoreConfig.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9655      +/-   ##
=============================================
- Coverage      48.12%   48.01%   -0.11%     
+ Complexity     12076    12050      -26     
=============================================
  Files           1313     1313              
  Lines          92837    92841       +4     
  Branches       11868    11868              
=============================================
- Hits           44677    44579      -98     
- Misses         42650    42741      +91     
- Partials        5510     5521      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]The bufferLocal size of the TimerMessageStore not enough

4 participants