-
Notifications
You must be signed in to change notification settings - Fork 12k
[RIP-81] Master-slave metadata incremental synchronization #9617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Crazylychee
wants to merge
9
commits into
apache:develop
Choose a base branch
from
Crazylychee:rip-80
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Increased snapshot storage interval to reduce the increased garbage collection frequency caused by deep copies 3. Added DataVersion transmission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9616
Brief Description
Master Node:
MetadataChangeObserver serves as a monitoring interface, extending two subclasses, NoopMetadataChangeObserver and SyncMetadataChangeObserver, for implementing no-op and synchronous message sending, respectively. Configuration map operations in configuration classes such as TimerMetrics, MessageRequestModeManager, ScheduleMessageService, ConsumerOffsetManager, SubscriptionGroupManager, and TopicConfigManager have been modified: Compute methods are used to ensure the atomicity of message sending and in-memory configuration updates, ensuring simultaneous success and failure to prevent data inconsistencies.
For the frequently updated consumerOffset, a dual buffering approach is implemented, with scheduled and buffer-full synchronous message sending strategies. This reduces the synchronous message sending burden caused by frequent consumerOffset updates. The scheduled strategy also mitigates the long inconsistency window caused by the buffer-full strategy in low-frequency updates.
A scheduled task is used to store the latest metadata snapshot, which contains the current metadata and the maximum offset of the corresponding system topic.
Methods for obtaining snapshots from the master node are defined in the AdminBrokerProcessor and BrokerOuterAPIs.
Slave nodes:
How Did You Test This Change?
broker config
Relevant work is already in progress. Proposal documentation is available here:
English version:
https://docs.google.com/document/d/1Q4dckYs5ALt_BM5aId9-3N9-kaGL-cLYvAVhv9Mc7bs/edit?usp=sharing
Chinese version:
https://m0sgzrp00oj.feishu.cn/docx/CvbedEJXto7A2BxfYVXcLXATnbd?from=from_copylink