Skip to content

[ISSUE #9288] Support the disablement of producer registration and fast channel shutdown#9293

Merged
lizhimins merged 4 commits intoapache:developfrom
ymwneu:channelEventOpt
Apr 11, 2025
Merged

[ISSUE #9288] Support the disablement of producer registration and fast channel shutdown#9293
lizhimins merged 4 commits intoapache:developfrom
ymwneu:channelEventOpt

Conversation

@ymwneu
Copy link
Contributor

@ymwneu ymwneu commented Mar 28, 2025

support reject producer when not transaction producer

Which Issue(s) This PR Fixes

Fixes #9288

Brief Description

  1. The current broker retains all producer channel information, which can consume a significant amount of resources when there are a large number of producers. In non-transactional message scenarios, the producer channel information is not useful. It would be beneficial to consider adding a switch to not record PID information in these scenarios.
  2. Support fast channel event processing to improve the speed of disconnection.

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 16.39344% with 102 lines in your changes missing coverage. Please review.

Project coverage is 47.96%. Comparing base (17d57ca) to head (b1495d9).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/client/ProducerManager.java 26.00% 30 Missing and 7 partials ⚠️
...mq/broker/client/ClientChannelAttributeHelper.java 0.00% 26 Missing ⚠️
...apache/rocketmq/broker/client/ConsumerManager.java 11.11% 22 Missing and 2 partials ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 12 Missing ⚠️
...rocketmq/client/impl/factory/MQClientInstance.java 0.00% 2 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9293      +/-   ##
=============================================
- Coverage      48.02%   47.96%   -0.06%     
- Complexity     12114    12117       +3     
=============================================
  Files           1322     1323       +1     
  Lines          93250    93375     +125     
  Branches       11958    11994      +36     
=============================================
+ Hits           44785    44790       +5     
- Misses         42922    43025     +103     
- Partials        5543     5560      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #9288] Support the disablement of producer registration and fast channel shutdown. [ISSUE #9288] Support the disablement of producer registration and fast channel shutdown Apr 11, 2025
@lizhimins lizhimins merged commit 775eb64 into apache:develop Apr 11, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Support the disablement of producer registration and fast channel shutdown.

4 participants