[ISSUE #6728] Compute the confirmOffset without considering new connections #6729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions. 2. When compute the confirmOffset, use getConfirmOffsetDirectly() to avoid the endless calling.
echooymxq
reviewed
May 10, 2023
Comment on lines
432
to
437
| long slaveAckOffset = connection.getSlaveAckOffset(); | ||
| if (slaveAckOffset <= 0) { | ||
| // Slave's connection is just inited, the ack hasn't been calculated. | ||
| // So skip this ackOffset. | ||
| continue; | ||
| } |
There was a problem hiding this comment.
if (currentSyncStateSet.contains(slaveId) && connection.getSlaveAckOffset() > 0) {
...
}There was a problem hiding this comment.
Yes, I have optimized this logic as you said.
Codecov Report
@@ Coverage Diff @@
## develop #6729 +/- ##
=============================================
- Coverage 42.88% 42.83% -0.05%
+ Complexity 9009 8995 -14
=============================================
Files 1113 1113
Lines 78587 78601 +14
Branches 10221 10224 +3
=============================================
- Hits 33700 33667 -33
- Misses 40669 40711 +42
- Partials 4218 4223 +5
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
approved these changes
May 11, 2023
lyx2000
pushed a commit
to lyx2000/rocketmq
that referenced
this pull request
Jun 30, 2023
… connections (apache#6729) * 1. When compute the confirmOffset, dismiss the ackOffset of new connections. 2. When compute the confirmOffset, use getConfirmOffsetDirectly() to avoid the endless calling. * use the calculated slaveAckOffset * optimize the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ISSUE #6728] Compute the confirmOffset without considering new connections.
Which Issue(s) This PR Fixes
Fixes #6728
Brief Description
How Did You Test This Change?