Skip to content

ExtConsumerResetConfiguration.java 中的 registerTemplate 方法存在问题 #718

Open
@gotoxu

Description

@gotoxu

代码片段

    SimpleConsumerBuilder consumerBuilder = null;
    SimpleConsumer simpleConsumer = null;
    SimpleConsumerInfo simpleConsumerInfo = null;


    try {
        final ClientServiceProvider provider = ClientServiceProvider.loadService();
        SimpleConsumerBuilder simpleConsumerBuilder = provider.newSimpleConsumerBuilder();
        simpleConsumerInfo = createConsumer(annotation, simpleConsumerBuilder);
    } catch (Exception e) {
        log.error("Failed to startup SimpleConsumer for RocketMQTemplate {}", beanName, e);
    }
    RocketMQClientTemplate rocketMQTemplate = (RocketMQClientTemplate) bean;
    rocketMQTemplate.setSimpleConsumerBuilder(consumerBuilder);
    rocketMQTemplate.setSimpleConsumer(simpleConsumer);

这里是否应改成:

SimpleConsumerBuilder consumerBuilder = null;
SimpleConsumer simpleConsumer = null;
SimpleConsumerInfo simpleConsumerInfo = null;

try {
  final ClientServiceProvider provider = ClientServiceProvider.loadService();
  consumerBuilder = provider.newSimpleConsumerBuilder();
  simpleConsumerInfo = createConsumer(annotation, consumerBuilder);
  simpleConsumer = consumerBuilder.build();
} catch (Exception e) {
  log.error("Failed to startup SimpleConsumer for RocketMQTemplate {}", beanName, e);
}

RocketMQClientTemplate rocketMQClient = (RocketMQClientTemplate) bean;
rocketMQClient.setConsumerBuilder(consumerBuilder);
rocketMQClient.setConsumer(simpleConsumer );

请确认一下

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions