Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance the send delayed message interface to include a message send timeout. #676

Open
1 task done
magestacks opened this issue Aug 21, 2024 · 0 comments

Comments

@magestacks
Copy link
Member

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Multiple overloaded methods of RocketMQTemplate#syncSendDelayTimeSeconds do not support a custom timeout parameter.

The RocketMQTemplate#syncSend method that supports custom configurations is private.

/**
 * Same to {@link #syncSend(String, Message)} with send timeout and delay time specified in addition.
 * This function is only valid when the broker version is 5.0 or above
 *
 * @param destination formats: `topicName:tags`
 * @param message {@link org.springframework.messaging.Message}
 * @param timeout send timeout with millis
 * @param delayTime delay time for message
 * @return {@link SendResult}
 */
private SendResult syncSend(String destination, Message<?> message, long timeout, long delayTime, DelayMode mode) {
    // ......
}

Motivation

Hope to include a custom timeout parameter when sending any delayed messages.

Describe the Solution You'd Like

Add an additional overloaded method for RocketMQTemplate#syncSendDelayTimeSeconds, or change the visibility of the RocketMQTemplate#syncSend method to public.

If you agree with this enhancement, I can submit a PR.

Describe Alternatives You've Considered

Add an additional overloaded method for RocketMQTemplate#syncSendDelayTimeSeconds, or change the visibility of the RocketMQTemplate#syncSend method to public.

If you agree with this enhancement, I can submit a PR.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant