Skip to content

Conversation

asmgf
Copy link

@asmgf asmgf commented Jul 29, 2025

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Currently the main page title includes untranslated tagline (官方网站):
image

This is quite confusing, e.g. when viewing Google search results -- not clear if this is the right page to open.
image

Brief changelog

Set tagline according to locale environment variable, as described in facebook/docusaurus#4542 (comment)

Verifying this change

npm run build
  • Verify build/index.html has translated title.
<title data-rh="true">RocketMQ · Official Website | RocketMQ</title>
  • Verify build/zh/index.html has original title.
<title data-rh="true">RocketMQ · 官方网站 | RocketMQ</title>

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant