Skip to content

Conversation

Crazylychee
Copy link
Contributor

@Crazylychee Crazylychee commented Jun 12, 2025

What is the purpose of the change

[RIP-78] part05

Brief changelog

fix #303
fix #305
fix #294
fix #245
fix #243
fix #264
fix #308

Verifying this change

jdk8 to jdk17
springboot 2.6 to springboot 3.4.5
remove acl1.0 and support acl2.0

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Crazylychee Crazylychee changed the title [GSOC][RIP-78][ISSUES#308]: Add part of refactored backend files [GSOC][RIP-78][ISSUES#308]: Add refactored backend files Jun 12, 2025
@Crazylychee Crazylychee changed the title [GSOC][RIP-78][ISSUES#308]: Add refactored backend files [RIP-78-5]: Add refactored backend files Jun 13, 2025
@HattoriHenzo
Copy link

Hello @Crazylychee and good job. There are some remaining refactoring about Spring Boot. As an example we can remove the use of @Autowired annotation that is no longer needed since the version Spring 4.3.
You can check this PR I made as an attempt or a POC for the migration, you will find some refactoring samples: #306

@Crazylychee
Copy link
Contributor Author

Hello @Crazylychee and good job. There are some remaining refactoring about Spring Boot. As an example we can remove the use of @Autowired annotation that is no longer needed since the version Spring 4.3. You can check this PR I made as an attempt or a POC for the migration, you will find some refactoring samples: #306

Oh, I get it. You may mean that we can replace the '@Autowired' and '@resource' of using the Allargsconstructor. That's a good idea. And are you willing to take a pr based on the lastest master?

@HattoriHenzo
Copy link

@Crazylychee Good point, I will take a look on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment