[#5538] message type was missing from TopicConfigInfo in rocketmq-das… #158
Conversation
|
@Oliverwqcwrw Please review this when available |
Hi @Oliverwqcwrw sorry for delaying this. |
|
|
@Oliverwqcwrw from where I have to add message type in frontend ? |
@Koudinka I have already added mesageType in TopicConfigInfo. I don't understand Oliver's first point The page also needs to add messageType |
The page is here |
|
@Oliverwqcwrw sorry for delaying this. |
| } | ||
|
|
||
| public void setMessageType(TopicConfig topicConfig) { | ||
| this.messageType = topicConfig.getAttributes().getOrDefault("message.type", ""); |
There was a problem hiding this comment.
It is better to set NORMAL when the message type is empty,
WDYT
There was a problem hiding this comment.
Yes right that will be more verbose.
@Oliverwqcwrw done please check.
There was a problem hiding this comment.
There are two small problems outside of the presentation
- It doesn't take effect when creating a topic with a message type; for example, it still remains as NORMAL when I create a FIFO topic.
- It would be more user-friendly to let the user choose from a message type drop-down box when creating a topic.
|
There should update TopicConfig attributes when create or update topic . |
What is the purpose of the change
#5538 - issue reported for examine Topic Config Query not returning message.type in query result.