Skip to content

Conversation

@githublaohu
Copy link
Contributor

What is the purpose of the change

Step-by-step unit testing

Brief changelog

Verifying this change

see test/src/message

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

* See the License for the specific language governing permissions and
* limitations under the License.
*/
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already processed

PRODUCER_SEND_ONEWAY_FAILED = 12,
PRODUCER_SEND_ORDERLY_FAILED = 13,
PRODUCER_SEND_ASYNC_FAILED = 14,
PRODUCER_SEND_ASYNC_FAILED = 14,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use space, not tab.

@ShannonDing ShannonDing added this to the 1.2.2 milestone Feb 12, 2019
@ShannonDing ShannonDing merged commit 41ea38d into apache:master Feb 15, 2019
@ShannonDing ShannonDing changed the title First stage 1 Add test case for message and message queue. Feb 20, 2019
@ShannonDing ShannonDing added the unit test unit test label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unit test unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants