[ISSUE #77] optimize process of allocate opaque by atomic without lock. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifplusor
force-pushed
the
optimize-opaque
branch
from
bf6e631 to
2bab750
Compare
ifplusor
force-pushed
the
optimize-opaque
branch
from
2bab750 to
2223b1c
Compare
lizhanhui
reviewed
Jan 28, 2019
src/protocol/RemotingCommand.cpp
Outdated
| ++s_seqNumber; | ||
|
|
||
| // mask sign bit | ||
| m_opaque = s_seqNumber.fetch_add(1, boost::memory_order_acq_rel) & numeric_limits<int>::max(); |
Contributor
There was a problem hiding this comment.
As we only need an atomic incremental number and no memory barrier is required, boost::memory_order_relaxed should be fine here.
Contributor
Author
There was a problem hiding this comment.
yeah. yesterday, i change this to 'memory_order_acq_rel' when i try to fix other bug, but that have no relation to memory order. i have revert it.
ifplusor
force-pushed
the
optimize-opaque
branch
from
81db531 to
ceb6cd7
Compare
Contributor
|
+1 to get this pull request merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 replace lock with fetch_add(1) when allocate opaque