Skip to content

[ISSUE #303] Catch exception when resolve domain failed#311

Merged
ifplusor merged 1 commit intoapache:masterfrom
ifplusor:dns-failed
May 26, 2020
Merged

[ISSUE #303] Catch exception when resolve domain failed#311
ifplusor merged 1 commit intoapache:masterfrom
ifplusor:dns-failed

Conversation

@ifplusor
Copy link
Contributor

What is the purpose of the change

Avoid crash when resolve domain failed.

Brief changelog

Catch exception when resolve domain failed.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ifplusor ifplusor added the bug Something isn't working label May 22, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   59.01%   59.01%           
=======================================
  Files         205      205           
  Lines       12985    12985           
=======================================
  Hits         7663     7663           
  Misses       5322     5322           
Impacted Files Coverage Δ
src/transport/TcpTransport.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f52615...c9a63b0. Read the comment docs.

@ifplusor ifplusor requested a review from ShannonDing May 22, 2020 06:05
@ifplusor ifplusor merged commit cb4599c into apache:master May 26, 2020
@ifplusor ifplusor deleted the dns-failed branch May 26, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash on ubuntu 18.04, verson: 2.1.0 Crash when network is down on Mac.

3 participants