Introduce Google test and Google mock infra #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
githublaohu
changed the title
githublaohu
changed the title
jovany-wang
reviewed
Dec 21, 2018
Contributor
jovany-wang
left a comment
jovany-wang
left a comment
There was a problem hiding this comment.
Left some small comments about lint.
CMakeLists.txt
Outdated
| add_subdirectory(libs) | ||
| add_subdirectory(project) | ||
| add_subdirectory(example) | ||
| add_subdirectory(test) No newline at end of file |
Contributor
There was a problem hiding this comment.
Please add a new line at the end of this file.
Contributor
Author
There was a problem hiding this comment.
Already processed
build.sh
Outdated
| mkdir -p ${build_dir} | ||
| fi | ||
|
|
||
| BuildGoogleTest() | ||
| { | ||
|
|
Contributor
There was a problem hiding this comment.
Remove this empty line?
Contributor
Author
There was a problem hiding this comment.
Already processed
test/CMakeLists.txt
Outdated
| include_directories(${Boost_INCLUDE_DIRS}) | ||
|
|
||
|
|
||
| set(Gtest_INCLUDE_DIR ${CMAKE_SOURCE_DIR}/bin/include/gtest) |
Contributor
There was a problem hiding this comment.
set(Gtest_INCLUDE_DIR ${CMAKE_SOURCE_DIR}/bin/include/gtest)
Just use 1 space between 2 args.
Contributor
Author
There was a problem hiding this comment.
Already processed
test/CMakeLists.txt
Outdated
| target_link_libraries (${basename} rocketmq_shared ${deplibs}) | ||
| target_link_libraries (${basename} rocketmq_shared ${Gtest_LIBRARIES}) | ||
| target_link_libraries (${basename} rocketmq_shared ${Gmock_LIBRARIES}) | ||
| #else() |
Contributor
There was a problem hiding this comment.
If these codes are useless, could you plz remove them?
Contributor
Author
There was a problem hiding this comment.
Already processed
test/CMakeLists.txt
Outdated
| include_directories(${Gmock_INCLUDE_DIR}) | ||
| include_directories(${Gmock_INCLUDE_DIR}/internal) | ||
|
|
||
| set(Gtest_LIBRARY_DIRS ${CMAKE_SOURCE_DIR}/bin/lib) |
Contributor
Author
There was a problem hiding this comment.
Already processed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of test library Google test and google mock to provide unit and integration test functions