Dependency c header instead of cpp header#15
Conversation
|
move define to common.h |
include/RocketMQClient.h
Outdated
| #else | ||
| #define ROCKETMQCLIENT_API | ||
| #endif | ||
| #include "CCommon.h" |
There was a problem hiding this comment.
Keep the two sets of Interfaces independent of each other. This macro can be repeatedly defined here.
Please remove the reference of the c head file.
There was a problem hiding this comment.
the cpp also need exports class and function
1.CPP interface will depend on C interface .
2. C interface independent the CPP interface
There was a problem hiding this comment.
This macro ROCKETMQCLIENT_API should be definded in CPP and C head file independently.
There was a problem hiding this comment.
done,add a new file CPPCommon.h,pls check new commit.
include/CCommon.h
Outdated
|
|
||
| #ifndef __C_COMMON_H__ | ||
| #define __C_COMMON_H__ | ||
| #include "RocketMQClient.h" |
There was a problem hiding this comment.
Remove this include head file.
| #else | ||
| #define ROCKETMQCLIENT_API | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Keep this macro here, it is not necessary to create a new head file, i think.
include/CPPCommon.h
Outdated
| #ifdef __cplusplus | ||
| }; | ||
| #endif | ||
| #endif //__C_COMMON_H__ |
There was a problem hiding this comment.
It is better to move this macro to the old head file RocketMQClient.h
There was a problem hiding this comment.
done,remove CPPCommon.h .
vongosling
changed the title
3 participants
1.move ROCKETMQCLIENT_EXPORTS to common.h