[ISSUE #121]Support connect MQ endpoint with ACL #133
Conversation
duhenglucky
changed the title
|
@jonnxu Could you please review this PR, is there any side effect on the batch send method that you request before? |
| keywords::max_size = 200 * 1024 * 1024, // max keep 3 log file defaultly | ||
| keywords::auto_flush = true); | ||
| logging::core::get()->set_filter(logging::trivial::severity >= logging::trivial::info); | ||
| // logging::core::get()->set_filter(logging::trivial::severity >= logging::trivial::info); |
| //<!************************************************************************ | ||
| } //<!end namespace; | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more |
| } | ||
| return nameServerAddr; | ||
| } | ||
| } // namespace rocketmq |
There was a problem hiding this comment.
Flag of the right brave of the rocketmq namespace.
| requestMap.insert(pair<string, string>("reconsumeTimes", UtilAll::to_string(reconsumeTimes))); | ||
| requestMap.insert(pair<string, string>("unitMode", UtilAll::to_string(unitMode))); | ||
| #endif | ||
| requestMap.insert(pair<string, string>("batch", UtilAll::to_string(batch))); |
There was a problem hiding this comment.
here i think there will problem for send message to broker with signature, because produce signature by spas_sign in doBeforeRequest depends on all header fields
void ClientRPCHook::doBeforeRequest(const string& remoteAddr, RemotingCommand& request) {
。。。。
header->SetDeclaredFieldOfCommandHeader(requestMap);
map<string, string>::iterator it = requestMap.begin();
for (; it != requestMap.end(); ++it) {
totalMsg.append(it->second);
}
if (request.getMsgBody().length() > 0) {
totalMsg.append(request.getMsgBody());
}
char* pSignature =
rocketmqSignature::spas_sign(totalMsg.c_str(), totalMsg.size(), sessionCredentials.getSecretKey().c_str());
}
There was a problem hiding this comment.
The server will not verify this field in the command header.
3 participants
What is the purpose of the change
[ISSUE #121 ]Support connect MQ endpoint
Brief changelog
Change the signature context for send message
Support Aliyun MQ endpoint URL parser
Add function and line in the log file
Verifying this change
Two kinds of Aliyun MQ topics:
topic for default instance(without InstanceID)
fulfill the name server address with endpoint and set ak, sk using the Session Credential API.
topic for your own InstanceID
change the GID to InstanceID+GID(InstanceID%GID),
change the topic to InstanceID+GID(InstanceID%GID),
fulfill the name server address with endpoint and set ak, sk using the Session Credential API.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.