unit-test-transport #110
Merged
unit-test-transport #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnxu
reviewed
Mar 25, 2019
| } | ||
|
|
||
| TEST(clientRemotingProcessorS, getConsumerRunningInfo) { | ||
| MockMQClientFactory *factory = new MockMQClientFactory("testClientId", 4, 3000, 4000, "a"); |
Contributor
There was a problem hiding this comment.
factory and info not deleted, please check the other TEST for not free the object, or use shared_ptr. also i think you can use local object, no need with new
Contributor
Author
There was a problem hiding this comment.
Mock::AllowLeak(factory); Be equal to deleted
Contributor
There was a problem hiding this comment.
but there are many point without Mock::AllowLeak
| using Json::FastWriter; | ||
| using Json::Value; | ||
|
|
||
| using rocketmq::ClientRemotingProcessor; |
Contributor
There was a problem hiding this comment.
for use so many class under namespace rocketmq, i think you can use "using namespace rocketmq" replace of "using rocketmq::*"
| using testing::Return; | ||
|
|
||
| TEST(MQDecoderTest, messageProperties2String) { |
Contributor
There was a problem hiding this comment.
why delete TEST(MQDecoderTest, messageProperties2String)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit-test-transport