RATIS-1390. Bootstrapping Peer should always try to install a snapshot the first time. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanishakoneru
force-pushed
the
RATIS-1390
branch
from
d67c91d to
8d3a476
Compare
szetszwo
reviewed
Aug 16, 2021
There was a problem hiding this comment.
@hanishakoneru , thanks a lot for working on this. Two minor comments about the names.
BTW, should we also add a new test?
| @@ -52,6 +52,14 @@ | |||
| /** Set follower's snapshotIndex. */ | |||
| void setSnapshotIndex(long newSnapshotIndex); | |||
|
|
|||
| /** Acknowledge that Follower attempted to install a snapshot. It does not guarantee that the installation was | |||
| * successful. This helps to determine whether Follower can come out of bootstrap process. */ | |||
| void ackInstallSnapshotAttempt(); | |||
There was a problem hiding this comment.
Let's use a name similar to hasAttemptedToInstallSnapshot(). How about "setAttemptedToInstallSnapshot"?
| @@ -148,6 +148,7 @@ enum InstallSnapshotResult { | |||
| IN_PROGRESS = 2; | |||
| ALREADY_INSTALLED = 3; | |||
| CONF_MISMATCH = 4; | |||
| NULL_SNAPSHOT = 5; | |||
There was a problem hiding this comment.
How about calling it as SNAPSHOT_UNAVALIABLE?
There was a problem hiding this comment.
Sure. Updated.
|
Thanks @szetszwo for the review. I have addressed your comments and added 2 unit tests. |
szetszwo
reviewed
Aug 19, 2021
|
The failing tests look unrelated and pass locally. I have retriggered CI. |
szetszwo
approved these changes
Aug 22, 2021
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 20, 2024
…t the first time. (apache#489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a peer is bootstrapping and joins the Ratis ring via SetConf request, the Leader adds the peer to the sender list and sends it either the append log entries or the snapshot or a notification to install snapshot via State Machine. The leader sends the snapshot only when some or all of the ratis logs have been purged.
The snapshot is maintained by the State Machine and as such could contain information not present in the Ratis logs (for example Ozone's OzoneManager StateMachine maintains the snapshot as a DB file and it could contain information which cannot be constructed just using the Ratis logs - HDDS-5338).
To avoid this scenario, this Jira proposes that whenever a new peer is bootstrapping, the leader should send an install snapshot request at least once.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1390
How was this patch tested?
Will add a unit test in next iteration.