RATIS-2282. LogAppender Restart Due to Premature Log Entry Access During Concurrent Write Processing #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo Plz review. |
szetszwo
reviewed
Apr 19, 2025
Comment on lines
522
to
524
| if (records.contains(index)) { | ||
| return records.get(index); | ||
| } |
There was a problem hiding this comment.
Just return without calling contain(..):
LogRecord getLogRecord(long index) {
return records.get(index);
}
Comment on lines
120
to
122
| boolean contains(long index) { | ||
| return map.containsKey(index); | ||
| } |
There was a problem hiding this comment.
contain(..) is not needed.
|
@szetszwo, thanks for your suggestion. It looks better. |
szetszwo
approved these changes
Apr 20, 2025
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 19, 2025
…ing Concurrent Write Processing (apache#1249)
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 19, 2025
…ing Concurrent Write Processing (apache#1249)
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
…ing Concurrent Write Processing (apache#1249)
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
…ing Concurrent Write Processing (apache#1249)
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
May 23, 2025
…ing Concurrent Write Processing (apache#1249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Put entry to cache before adding the record.
modify the getLogRecord function with contains.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2282
How was this patch tested?
unit tests