RATIS-2176. Update doc for raft.server.log.appender.wait-time.min.

.asf.yaml

@@ -24,7 +24,9 @@ github:
     squash:  true
     merge:   false
     rebase:  false
-  autolink_jira: RATIS
+  autolink_jira:
+    - HDDS
+    - RATIS
 
 notifications:
   commits:      commits@ratis.apache.org

.github/workflows/post-commit.yml

@@ -14,18 +14,23 @@
 # limitations under the License.
 name: build-branch
 on:
-  - push
-  - pull_request
+  push:
+    branches-ignore:
+      - 'dependabot/**'
+    tags:
+      - '**'
+  pull_request:
 env:
   WITH_COVERAGE: true
 jobs:
   build:
     runs-on: ubuntu-20.04
+    timeout-minutes: 30
     steps:
       - name: Checkout project
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Cache for maven dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/.m2/repository
@@ -34,44 +39,45 @@ jobs:
           restore-keys: |
             maven-repo-
       - name: Setup java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
           java-version: 8
       - name: Run a full build
-        run: ./dev-support/checks/build.sh -Prelease assembly:single
+        run: ./dev-support/checks/build.sh -Prelease
       - name: Store binaries for tests
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ratis-bin
           path: |
-            ratis-assembly/target/apache-ratis-*.tar.gz
-            !ratis-assembly/target/apache-ratis-*-src.tar.gz
+            ratis-assembly/target/ratis-assembly-*.tar.gz
+            !ratis-assembly/target/ratis-assembly-*-src.tar.gz
           retention-days: 1
       - name: Store source tarball for compilation
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ratis-src
-          path: ratis-assembly/target/apache-ratis-*-src.tar.gz
+          path: ratis-assembly/target/ratis-assembly-*-src.tar.gz
           retention-days: 1
   compile:
     needs:
       - build
     runs-on: ubuntu-20.04
+    timeout-minutes: 30
     strategy:
       matrix:
-        java: [ 11 ]
+        java: [ 11, 17, 21 ]
       fail-fast: false
     steps:
       - name: Download source tarball
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: ratis-src
       - name: Untar sources
         run: |
-          tar --strip-components 1 -xzvf apache-ratis-*-src.tar.gz
+          tar --strip-components 1 -xzvf ratis-assembly-*-src.tar.gz
       - name: Cache for maven dependencies
-        uses: actions/cache/restore@v3
+        uses: actions/cache/restore@v4
         with:
           path: |
             ~/.m2/repository
@@ -80,20 +86,23 @@ jobs:
           restore-keys: |
             maven-repo-
       - name: Setup java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
           java-version: ${{ matrix.java }}
       - name: Run a full build
-        run: ./dev-support/checks/build.sh
+        run: ./dev-support/checks/build.sh -Djavac.version=${{ matrix.java }}
+      - name: Test reproducibility
+        run: ./dev-support/checks/repro.sh -Djavac.version=${{ matrix.java }}
   rat:
     name: rat
     runs-on: ubuntu-20.04
+    timeout-minutes: 15
     steps:
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
         - name: Cache for maven dependencies
-          uses: actions/cache/restore@v3
+          uses: actions/cache/restore@v4
           with:
             path: |
               ~/.m2/repository
@@ -104,28 +113,30 @@ jobs:
         - name: Run tests
           run: ./dev-support/checks/rat.sh
         - name: Upload results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: always()
           with:
             name: rat
             path: target/rat
   author:
     name: author
     runs-on: ubuntu-20.04
+    timeout-minutes: 15
     steps:
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
         - name: Run tests
           run: ./dev-support/checks/author.sh
         - name: Upload results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: always()
           with:
             name: author
             path: target/author
   unit:
     name: unit
     runs-on: ubuntu-20.04
+    timeout-minutes: 60
     strategy:
       matrix:
         profile:
@@ -134,15 +145,10 @@ jobs:
           - misc
       fail-fast: false
     steps:
-        # TEMPORARY WHILE GITHUB FIXES https://github.com/actions/virtual-environments/issues/3185
-        - name: Add the current IP address, long hostname and short hostname record to /etc/hosts file
-          run: |
-            echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
-        # REMOVE CODE ABOVE WHEN ISSUE IS ADDRESSED!
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
         - name: Cache for maven dependencies
-          uses: actions/cache/restore@v3
+          uses: actions/cache/restore@v4
           with:
             path: |
               ~/.m2/repository
@@ -151,7 +157,7 @@ jobs:
             restore-keys: |
               maven-repo-
         - name: Setup java
-          uses: actions/setup-java@v3
+          uses: actions/setup-java@v4
           with:
             distribution: 'temurin'
             java-version: 8
@@ -161,19 +167,20 @@ jobs:
           run: cat target/${{ github.job }}/summary.txt
           if: ${{ !cancelled() }}
         - name: Upload results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: ${{ !cancelled() }}
           with:
             name: unit-${{ matrix.profile }}
             path: target/unit
   checkstyle:
     name: checkstyle
     runs-on: ubuntu-20.04
+    timeout-minutes: 15
     steps:
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
         - name: Cache for maven dependencies
-          uses: actions/cache/restore@v3
+          uses: actions/cache/restore@v4
           with:
             path: |
               ~/.m2/repository
@@ -184,24 +191,25 @@ jobs:
         - name: Run tests
           run: ./dev-support/checks/checkstyle.sh
         - name: Upload results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: always()
           with:
             name: checkstyle
             path: target/checkstyle
   findbugs:
     name: findbugs
     runs-on: ubuntu-20.04
+    timeout-minutes: 30
     steps:
         - name: Setup java
-          uses: actions/setup-java@v3
+          uses: actions/setup-java@v4
           with:
             distribution: 'temurin'
             java-version: 8
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
         - name: Cache for maven dependencies
-          uses: actions/cache/restore@v3
+          uses: actions/cache/restore@v4
           with:
             path: |
               ~/.m2/repository
@@ -212,7 +220,7 @@ jobs:
         - name: Run tests
           run: ./dev-support/checks/findbugs.sh
         - name: Upload results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: always()
           with:
             name: findbugs
@@ -222,14 +230,15 @@ jobs:
       - build
       - unit
     runs-on: ubuntu-20.04
+    timeout-minutes: 30
     if: (github.repository == 'apache/ratis' || github.repository == 'apache/incubator-ratis') && github.event_name != 'pull_request'
     steps:
         - name: Checkout project
-          uses: actions/checkout@v3
+          uses: actions/checkout@v4
           with:
             fetch-depth: 0
         - name: Cache for maven dependencies
-          uses: actions/cache/restore@v3
+          uses: actions/cache/restore@v4
           with:
             path: |
               ~/.m2/repository
@@ -238,18 +247,18 @@ jobs:
             restore-keys: |
               maven-repo-
         - name: Setup java 17
-          uses: actions/setup-java@v3
+          uses: actions/setup-java@v4
           with:
             distribution: 'temurin'
             java-version: 17
         - name: Download artifacts
-          uses: actions/download-artifact@v3
+          uses: actions/download-artifact@v4
           with:
             path: target/artifacts
         - name: Untar binaries
           run: |
             mkdir -p ratis-assembly/target
-            tar xzvf target/artifacts/ratis-bin/apache-ratis*.tar.gz -C ratis-assembly/target
+            tar xzvf target/artifacts/ratis-bin/ratis-assembly-*.tar.gz -C ratis-assembly/target
         - name: Calculate combined coverage
           run: ./dev-support/checks/coverage.sh
         - name: Upload coverage to Sonar
@@ -258,7 +267,7 @@ jobs:
             SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
             GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         - name: Archive build results
-          uses: actions/upload-artifact@v3
+          uses: actions/upload-artifact@v4
           if: always()
           with:
             name: ${{ github.job }}

.github/workflows/repeat-test.yml

@@ -87,11 +87,11 @@ jobs:
         split: ${{ fromJson(needs.prepare.outputs.matrix) }}
       fail-fast: ${{ fromJson(github.event.inputs.fail-fast) }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.inputs.ref }}
       - name: Cache for maven dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/.m2/repository
@@ -100,7 +100,7 @@ jobs:
           restore-keys: |
             maven-repo-
       - name: Setup java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
           java-version: 8
@@ -113,18 +113,18 @@ jobs:
         run: dev-support/checks/_summary.sh target/unit/summary.txt
         if: ${{ !cancelled() }}
       - name: Archive build results
-        uses: actions/upload-artifact@v3
-        if: always()
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() }}
         with:
-          name: result-${{ env.TEST_CLASS }}-split-${{ matrix.split }}
+          name: result-${{ github.run_number }}-${{ github.run_id }}-split-${{ matrix.split }}
           path: target/unit
   count-failures:
-    if: ${{ always() }}
+    if: ${{ failure() }}
     needs: test
     runs-on: ubuntu-20.04
     steps:
       - name: Download build results
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
       - name: Count failures
         run: |
           failures=$(find . -name 'summary.txt' | grep -v 'iteration' | xargs grep -v 'exit code: 0' | wc -l)

dev-support/checks/repro.sh

@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+cd "$DIR/../.." || exit 1
+
+source "${DIR}/../find_maven.sh"
+
+: ${WITH_COVERAGE:="false"}
+
+MAVEN_OPTIONS='-V -B -Dmaven.javadoc.skip=true -DskipTests --no-transfer-progress'
+
+if [[ "${WITH_COVERAGE}" != "true" ]]; then
+  MAVEN_OPTIONS="${MAVEN_OPTIONS} -Djacoco.skip"
+fi
+
+export MAVEN_OPTS="-Xmx4096m"
+${MVN} ${MAVEN_OPTIONS} clean verify artifact:compare "$@"
+exit $?

dev-support/checks/unit.sh

@@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do
   fi
 
   if [[ ${ITERATIONS} -gt 1 ]]; then
+    if ! grep -q "Running .*Test" "${REPORT_DIR}/output.log"; then
+      echo "No tests were run" >> "${REPORT_DIR}/summary.txt"
+      irc=1
+      FAIL_FAST=true
+    fi
+
     if [[ ${irc} == 0 ]]; then
       rm -fr "${REPORT_DIR}"
     fi