Skip to content

RATIS-2057. Add back JavaUtils.attemptUntilTrue(..). #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

szetszwo
Copy link
Contributor

@szetszwo szetszwo requested a review from adoroszlai April 15, 2024 23:31
@symious
Copy link
Contributor

symious commented Apr 16, 2024

@szetszwo Thank you for the update.

I saw the comments in "https://issues.apache.org/jira/browse/RATIS-2058" that says "Other classes (e.g. JavaUtils, JvmPauseMonitor, DataQueue) may not necessarily be.", does that mean applications should not use "JavaUtils" in the future since it's not in "ratis-common-api"?

@adoroszlai
Copy link
Contributor

Thanks @szetszwo for the patch.

@adoroszlai adoroszlai merged commit cf9d229 into apache:master Apr 16, 2024
@szetszwo
Copy link
Contributor Author

... does that mean applications should not use "JavaUtils" in the future ... ?

That's is a good question! For now, we may consider the APIs in classes like JavaUtils are experimental (similar to Java 9 jfr or grpc). We will make the APIs more stable when we establish the public ratis -common-api.

@szetszwo
Copy link
Contributor Author

@adoroszlai , thanks a lot for reviewing and merging this!

@symious
Copy link
Contributor

symious commented Apr 17, 2024

For now, we may consider the APIs in classes like JavaUtils are experimental (similar to Java 9 jfr or grpc). We will make the APIs more stable when we establish the public ratis -common-api.

@szetszwo Thank you for the explaination.

SzyWilliam pushed a commit to SzyWilliam/ratis that referenced this pull request Jun 12, 2024
szetszwo added a commit to szetszwo/ratis that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants