Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zookeeper to 3.9.2 #359

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

ksobolew
Copy link
Contributor

Upgrade zookeeper to 3.9.2 and exclude it from (most of) transitive dependencies.

@ksobolew
Copy link
Contributor Author

cc: @mneethiraj

@mneethiraj
Copy link
Contributor

@ksobolew - thank you for the patch. Ranger admin server fails during startup with this patch. Can you please review and update?

2024-07-26 18:30:55,849  [I] Ranger all admins default password change request is in process..
Exception in thread "main" java.lang.NoSuchMethodError: ch.qos.logback.core.util.Loader.systemClassloaderIfNull(Ljava/lang/ClassLoader;)Ljava/lang/ClassLoader;
	at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:73)
	at ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:66)
	at ch.qos.logback.classic.spi.LogbackServiceProvider.initializeLoggerContext(LogbackServiceProvider.java:52)
	at ch.qos.logback.classic.spi.LogbackServiceProvider.initialize(LogbackServiceProvider.java:41)
	at org.slf4j.LoggerFactory.bind(LoggerFactory.java:196)
	at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:183)
	at org.slf4j.LoggerFactory.getProvider(LoggerFactory.java:486)
	at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:472)
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:421)
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:447)
	at org.apache.ranger.patch.BaseLoader.<clinit>(BaseLoader.java:40)

@kumaab
Copy link
Contributor

kumaab commented Jul 26, 2024

Tests are failing, see logs:

2024-07-26T18:00:24.3482181Z [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.197 s <<< FAILURE! - in org.apache.ranger.authorization.kafka.authorizer.KafkaRangerAuthorizerTest
2024-07-26T18:00:24.3488516Z [ERROR] org.apache.ranger.authorization.kafka.authorizer.KafkaRangerAuthorizerTest  Time elapsed: 3.197 s  <<< ERROR!
2024-07-26T18:00:24.3490144Z java.lang.NoClassDefFoundError: org/apache/zookeeper/server/quorum/QuorumPeerConfig
2024-07-26T18:00:24.3491331Z 	at org.apache.curator.test.TestingServer.<init>(TestingServer.java:117)
2024-07-26T18:00:24.3492424Z 	at org.apache.curator.test.TestingServer.<init>(TestingServer.java:104)
2024-07-26T18:00:24.3493519Z 	at org.apache.curator.test.TestingServer.<init>(TestingServer.java:45)
2024-07-26T18:00:24.3495422Z 	at org.apache.ranger.authorization.kafka.authorizer.KafkaRangerAuthorizerTest.setup(KafkaRangerAuthorizerTest.java:104)
2024-07-26T18:00:24.3496872Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2024-07-26T18:00:24.3497678Z 	at java.util.ArrayList.forEach(ArrayList.java:1259)
2024-07-26T18:00:24.3498833Z Caused by: java.lang.ClassNotFoundException: org.apache.zookeeper.server.quorum.QuorumPeerConfig
2024-07-26T18:00:24.3500097Z 	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
2024-07-26T18:00:24.3501080Z 	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
2024-07-26T18:00:24.3502014Z 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
2024-07-26T18:00:24.3502933Z 	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
2024-07-26T18:00:24.3503606Z 	... 6 more

@mneethiraj
Copy link
Contributor

@ksobolew, @kumaab - following updates resolved the issue:

  • exclude ch.qos.logback:* from org.apache.zookeeper:zookeeper dependency
  • add org.apache.zookeeper:zookeeper test dependency in plugin-kafka

@mneethiraj mneethiraj merged commit 487457c into apache:master Jul 26, 2024
3 checks passed
mneethiraj pushed a commit that referenced this pull request Jul 26, 2024
…est #359)

Co-authored-by: Madhan Neethiraj <madhan@apache.org>
(cherry picked from commit 487457c)
@ksobolew ksobolew deleted the kudi/zookeeper branch July 29, 2024 07:04
@ksobolew
Copy link
Contributor Author

Thanks @mneethiraj for fixing those while I was away during the weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants