QPID-7615 Number of selectors can be equal to connection thread pool size #34
Conversation
alex-rufous
left a comment
alex-rufous
left a comment
There was a problem hiding this comment.
I suggest to split positive and negative tests into separate methods.
The positive tests can be strengthened with asserts verifying attributes values
|
|
||
| @Test | ||
| public void testCreateValidation() | ||
| public void testSelectorNumberMustBePositiveOnCreate() |
There was a problem hiding this comment.
I would like to suggest splitting positive and negative tests into separate methods
| public void testCreateValidation() | ||
| public void testSelectorNumberMustBePositiveOnCreate() | ||
| { | ||
| createVirtualHost(getTestName(), Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1")); |
There was a problem hiding this comment.
It make sense to verify that attribute "numberOfSelectors" is indeed set to the specified value, for example
Map<String, Object> attributes = Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1"); final QueueManagingVirtualHost<?> vh = createVirtualHost(getTestName(), attributes); assertEquals(1, vh.getNumberOfSelectors());
| } | ||
|
|
||
| @Test | ||
| public void testConnectionThreadPoolSizeMustBePositiveOnCreate() |
There was a problem hiding this comment.
Please, split method into positive and negative tests
| final Map<String, Object> vhAttributes = new HashMap<>(); | ||
| vhAttributes.put(QueueManagingVirtualHost.CONNECTION_THREAD_POOL_SIZE, 1); | ||
| vhAttributes.put(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, 1); | ||
| createVirtualHost(getTestName(), vhAttributes); |
There was a problem hiding this comment.
The test can be strengthen with asserts verifying that specified values are indeed set on the corresponding attributes
| } | ||
|
|
||
| @Test | ||
| public void testSelectorNumberMustBeLessOrEqualToThePoolSizeOnCreate() |
There was a problem hiding this comment.
I would like to suggest splitting positive and negative tests into separate methods
| { | ||
| QueueManagingVirtualHost<?> virtualHost = createVirtualHost(getTestName()); | ||
| final QueueManagingVirtualHost<?> virtualHost = createVirtualHost(getTestName()); | ||
| virtualHost.setAttributes(Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1")); |
There was a problem hiding this comment.
The test can be strengthen with asserts verifying that specified values are indeed set on the corresponding attributes
| } | ||
|
|
||
| @Test | ||
| public void testConnectionThreadPoolSizeMustBePositiveOnChange() |
There was a problem hiding this comment.
I would like to suggest splitting positive and negative tests into separate methods
| final Map<String, Object> vhAttributes = new HashMap<>(); | ||
| vhAttributes.put(QueueManagingVirtualHost.CONNECTION_THREAD_POOL_SIZE, 1); | ||
| vhAttributes.put(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, 1); | ||
| virtualHost.setAttributes(vhAttributes); |
There was a problem hiding this comment.
The test can be strengthen with asserts verifying that specified values are indeed set on the corresponding attributes
| } | ||
|
|
||
| @Test | ||
| public void testSelectorNumberMustBeLessOrEqualToThePoolSizeOnChange() |
There was a problem hiding this comment.
I would like to suggest splitting positive and negative tests into separate methods
| { | ||
| final QueueManagingVirtualHost<?> virtualHost = createVirtualHost(getTestName()); | ||
| virtualHost.setAttributes(Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, QueueManagingVirtualHost.DEFAULT_VIRTUALHOST_CONNECTION_THREAD_POOL_SIZE - 1)); | ||
| virtualHost.setAttributes(Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, QueueManagingVirtualHost.DEFAULT_VIRTUALHOST_CONNECTION_THREAD_POOL_SIZE)); |
There was a problem hiding this comment.
The test can be strengthen with asserts verifying that specified values are indeed set on the corresponding attributes
2 participants
Divided test testCreateValidation to
and test testChangeValidation to