Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 9535] Add metrics for the cursor ack state #9618

Conversation

limingnihao
Copy link
Contributor

Fixes #9535

Motivation

The acknowledgment state is persistent to the Ledger or Zookeeper(can't persistent to the Ledger). But currently, we don't have any metrics for the persistence of the acknowledgment state such as the total count of the success/failed persistent operations.

Modifications

Add metrics for the ManagedCursor:

brk_ml_cursor_persistLedgerSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistLedgerErrors(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"")

@gaoran10
Copy link
Contributor

/pulsarbot run-failure-checks

@limingnihao limingnihao force-pushed the issue-9535-Add-metrics-for-the-cursor-ack-state branch from 01ee478 to 0c1b762 Compare February 21, 2021 11:46
@codelipenghui codelipenghui added area/metrics release/2.7.1 doc-required Your PR changes impact docs and you will update later. labels Feb 21, 2021
@sijie sijie merged commit 99a907b into apache:master Feb 22, 2021
@Anonymitaet
Copy link
Member

@limingnihao thanks for your coding work, would you like to add docs for this change as well? I'd like to help review. Thanks

@Anonymitaet
Copy link
Member

@limingnihao any thoughts?

zymap pushed a commit that referenced this pull request Feb 25, 2021
Fixes #9535

The acknowledgment state is persistent to the Ledger or Zookeeper(can't persistent to the Ledger). But currently, we don't have any metrics for the persistence of the acknowledgment state such as the total count of the success/failed persistent operations.

Add metrics for the ManagedCursor:

brk_ml_cursor_persistLedgerSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistLedgerErrors(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"")

(cherry picked from commit 99a907b)
@zymap zymap added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Feb 25, 2021
codelipenghui pushed a commit that referenced this pull request Mar 4, 2021
Master Issue: #9535
Related PR: #9618

### Motivation
Add user notes on managed cursor acknowledgement stats.
@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label Mar 5, 2021
mlyahmed pushed a commit to mlyahmed/pulsar that referenced this pull request Mar 5, 2021
Master Issue: apache#9535
Related PR: apache#9618

### Motivation
Add user notes on managed cursor acknowledgement stats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for the cursor ack state
6 participants