-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 9535] Add metrics for the cursor ack state #9618
Merged
sijie
merged 3 commits into
apache:master
from
limingnihao:issue-9535-Add-metrics-for-the-cursor-ack-state
Feb 22, 2021
Merged
[Issue 9535] Add metrics for the cursor ack state #9618
sijie
merged 3 commits into
apache:master
from
limingnihao:issue-9535-Add-metrics-for-the-cursor-ack-state
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot run-failure-checks |
01ee478
to
0c1b762
Compare
codelipenghui
approved these changes
Feb 21, 2021
sijie
approved these changes
Feb 22, 2021
@limingnihao thanks for your coding work, would you like to add docs for this change as well? I'd like to help review. Thanks |
@limingnihao any thoughts? |
zymap
pushed a commit
that referenced
this pull request
Feb 25, 2021
Fixes #9535 The acknowledgment state is persistent to the Ledger or Zookeeper(can't persistent to the Ledger). But currently, we don't have any metrics for the persistence of the acknowledgment state such as the total count of the success/failed persistent operations. Add metrics for the ManagedCursor: brk_ml_cursor_persistLedgerSucceed(namespace="", ledger_name="", cursor_name:"") brk_ml_cursor_persistLedgerErrors(namespace="", ledger_name="", cursor_name:"") brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"") brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"") (cherry picked from commit 99a907b)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 4, 2021
mlyahmed
pushed a commit
to mlyahmed/pulsar
that referenced
this pull request
Mar 5, 2021
Master Issue: apache#9535 Related PR: apache#9618 ### Motivation Add user notes on managed cursor acknowledgement stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9535
Motivation
The acknowledgment state is persistent to the Ledger or Zookeeper(can't persistent to the Ledger). But currently, we don't have any metrics for the persistence of the acknowledgment state such as the total count of the success/failed persistent operations.
Modifications
Add metrics for the ManagedCursor:
brk_ml_cursor_persistLedgerSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistLedgerErrors(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"")