Allow to build Pulsar with JDK11 and -Dmaven.compiler.release=8 #9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
approved these changes
Feb 12, 2021
lhotari
reviewed
Feb 12, 2021
| @SuppressWarnings("restriction") | ||
| private static sun.management.HotspotRuntimeMBean runtime; | ||
| private static Object /*sun.management.HotspotRuntimeMBean*/ runtime; | ||
| private static Method getTotalSafepointTimeHandle; |
There was a problem hiding this comment.
nit: naming this getTotalSafepointTimeMethod instead of *Handle? Since there's also java.lang.invoke.MethodHandle which is different than java.lang.reflect.Method.
There was a problem hiding this comment.
I tried with method hanldes but I was not able to access the method.
So I did fall back to old reflection style
|
@eolivelli please follow up with an mr to update github workflows to use jdk11. |
|
@aahmed-se I wanted to do it, but in order to do it we have to work on the pulsar build images. Please commit this first simple step |
|
/pulsarbot rerun-failure-tests |
merlimat
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #9578
Motivation
If you try to build Pulsar on JDK11 and add the --release flag to javac (that is -Dmaven.compiler.release=8 in Maven terms) you see errors due to some internal APIs that have been hidden to the user at build time.
Modifications